feat: ability to verify e2e STARK proof + CLI command #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
requested changes
May 23, 2025
| @@ -322,6 +326,51 @@ impl<E: StarkFriEngine<SC>> GenericSdk<E> { | |||
| Ok(proof) | |||
| } | |||
|
|
|||
| pub fn verify_e2e_stark_proof( | |||
There was a problem hiding this comment.
Taking
openvm/crates/vm/src/arch/vm.rs
Line 735 in 4da0af9
crates/sdk/src/lib.rs
Outdated
| &self, | ||
| agg_stark_pk: AggStarkProvingKey, | ||
| proof: &VmStarkProof<SC>, | ||
| ) -> Result<[F; CHUNK]> { |
There was a problem hiding this comment.
Return AppExecutionCommit instead of just exe commit.
There was a problem hiding this comment.
vm_commit should be internal_committed_exe.get_program_commit()? Or should I get the program commit from the root verifier program?
There was a problem hiding this comment.
It's the program commit of leaf verifier or a public value of internal verifier. See here:
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: e7c6611 |
nyunyunyunyu
approved these changes
May 27, 2025
stephenh-axiom-xyz
added a commit
that referenced
this pull request
May 27, 2025
Resolves INT-4074. Primarily accomplishes the following:
- `cargo openvm prove` outputs proofs to `${bin_name}.app.proof` instead
of `app.proof`, where `bin_name` is the file stem of the executable
(same for `stark` and `evm`)
- `cargo openvm verify` by default searches the working directory for
files with extension `.app.proof`
Additionally, the following are also in this PR:
- `cargo openvm init ${dir}` creates directory `dir` if it doesn't
already exist
- Updates to the book to reflect recent CLI changes
The following were merged from #1689:
- SDK functionality to verify e2e STARK proofs
- `cargo openvm verify stark` subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves INT-4064